That said, The definitive ruling is in ...
The brace is OK if used as designed. If you get caught putting it up to your shoulder, you have "redesigned" your pistol into a SBR, and you may be committing a felony.
I wonder if several YouTube videos will suddenly disappear.
That bottom line is that ATF letter does not say anything about sales, and in fact, it says the opposite:
I may not like the ruling, but I like the way it's stated. Personal accountability. No more pleading ignorance and scraping off responsibility on the seller. And that's why statements made in YouTube videos could be inculpatory.ATF hereby confirms that if used as designed — to assist shooters in stabilizing a handgun while shooting with a single hand — the device is not considered a shoulder stock and therefore may be attached to a handgun without making a NFA firearm. *** The pistol stabilizing brace was neither “designed” nor approved to be used as a shoulder stock, and therefore use as a shoulder stock constitutes a “redesign” of the device because a possessor has changed the very function of the item. Any individual letters stating otherwise are contrary to the plain language of the NFA, misapply Federal law, and are hereby revoked.